MAINT pysoundfile -> soundfile #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Sounds like a good idea, pysoundfile was last updated 5 years ago, and soundfile is being maintained. The thing I'd watch out for is breaking changes, and it might be an idea to put that out in a corresponding major bump. However, the coverage here is really high, so if you have confidence in the tests, you could do it in a non-major too. I'd still probably lean towards a minor over patch. |
Member
Author
|
@hugovk OK so this would be versioned as 1.5.0 (minor), not 1.4.2 (bugfix)? We probably should make a beta release for that, right? |
Contributor
|
Yep, 1.5.0. I think beta releases are a good idea in theory, but in my experience, very few people ever try them, so it's usually better to just release. Release early, release often! Automated releases really help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came up in conversation with @adinhodovic while reviewing #153. Quote from soundfile:
I believe this is urgent and should happen as part of the 1.4.2 bugfix release. I don't know if that implies a break of compatibility?
@hugovk your thoughts?